Changeset 995

Timestamp:

04/16/02 16:27:56 (11 years ago)

Author:

bradfitz

Message:

<lj user=avva>: This patch fixes an oversight: the view of all
subjects per month didn't auto-translate old entries. Note I don't
load all the props of all the posts to check unknown8bit=1. Instead I
just check if the subject is UTF-8, if not, I convert. This'll work in
99.99999% of cases and is much faster, so, considering this view never
lets the user edit anything, I think it's a good tradeoff.

Tested.

Files:

• trunk/htdocs/view/index.bml (modified) (1 diff)

trunk/htdocs/view/index.bml

@@ -140 +140 @@
          $body .= "<dd><table cellpadding=2>";
      }
+
+     # we need to convert the subject to UTF-8 if it's a pre-Unicode entry
+     # loading all the props for all the posts and checking 'unknown8bit' 
+     # is too long. The heuristic "if it's not UTF-8, convert it" works
+     # well here.
+     if ($LJ::UNICODE && !LJ::is_utf8($subject)) {
+         my $error;
+         my $subj = LJ::text_convert($dbs, $subject, $u, \$error);
+         $subject = $subj unless $error;
+         LJ::text_out(\$subject);
+     }
+
      unless ($subject ne "") { $subject = "(no subject)"; }
      my $h = substr($eventtime, 11, 2);